Feat/door#22
Merged
Merged
Conversation
Replace raw `(i32, i32, i32)` tuples with the proper `BlockPos` type throughout the double doors module. Also updates `BlockFlags` construction to use explicit bitflags constants instead of builder-style methods, and switches the action check to use debug string comparison as a temporary workaround for upstream type visibility.
aliases Remove `Config` type aliases in favor of directly naming structs `DoubleDoorsConfig`, `LocatorConfig`, `PlayerConfig`, and `TablistConfig`. Also fixes `InteractAction` comparison to use the proper enum constant instead of string formatting.
This replaces the locator module with a new enderchest mechanic and adds an `actions` configuration field to the openable module, allowing users to specify which interaction types trigger door toggling. The server module file is also removed as its contents are re-exported elsewhere.
- Add `gamemodes` config field to restrict which gamemodes can trigger - Change default action from `RightClickAir` to `RightClickBlock` for doors - Update documentation table with new field and fix alignment
Introduces `GameMode` and `InteractionAction` mirror enums with serde support, replacing fragile string-based comparisons in `Enderchest` and `Openable` modules. Temporarily disables `Enderchest` module while the new types are being integrated.
- Replace `toml` crate with `serde_json` for serialization - Switch figment provider from TOML to JSON format - Update config file path from `config.toml` to `config.json` - Refactor ConfigManager to use `Serialized` provider and `serde_json::Value` - Update build commands in docs to reference PowerShell script - Remove obsolete `AI.md` documentation file
Register new `entity::bat` module with config, following existing module patterns. Module is currently a stub with no event handlers or commands.
Temporarily comment out Bat, Griefing, Enderchest, Locator, and Openable modules from registration until they are ready for use. Only Messages, Chat, and Tablist remain active.
Moves `GameMode` and `InteractionAction` from a single `mirror_types.rs` file into separate `mirror_types/gamemode.rs` and `mirror_types/interaction.rs` modules. Updates imports across enderchest and openable modules to use the new paths.
Introduces `src/mirror_types/` module with serial
- Add Bat module stub (phantom membrane drops on death, blocked by missing EntityDeathEvent in Pumpkin API). - Add Griefing module stub (cancels block changes and explosions for configured entity types, blocked by missing EntityChangeBlockEvent and EntityExplodeEvent). - Extract GriefingConfig.cancelled_entities into typed Vec<EntityType> for config-time validation. - Split mirror_types.rs into a folder: entity_type.rs, gamemode.rs, interaction.rs, matching lib.rs's nested mod style. - Comment out unfinished module registrations (Bat, Griefing, Enderchest, Locator, Openable) so only Messages, Chat, Tablist are active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?