Skip to content

staging environment#183

Merged
ishaanxgupta merged 4 commits into
mainfrom
develop
May 17, 2026
Merged

staging environment#183
ishaanxgupta merged 4 commits into
mainfrom
develop

Conversation

@ishaanxgupta
Copy link
Copy Markdown
Member

No description provided.

@ishaanxgupta ishaanxgupta requested a review from ved015 as a code owner May 17, 2026 09:49
@github-actions
Copy link
Copy Markdown

Fails
🚫

📋 PR description is too short. Please describe:

  • What changed and Why
  • Any relevant issue links (Closes #NNN)
  • Steps to test manually
Warnings
⚠️

📦 This PR changes 984 lines (additions + deletions). Large PRs are harder to review thoroughly — consider splitting it.

Messages
📖

📝 No CHANGELOG.md update detected. If this PR introduces a user-visible change, please add an entry.

📖

✅ Targeting main. Please squash commits before merging to keep the git history clean.

Generated by 🚫 dangerJS against fd8732e

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a standardized pull request template and a Dangerfile.js to automate CI checks, including PR size warnings, test requirements for source changes, and protection for sensitive files. The review feedback suggests improving the source change detection logic to include newly created files and refining the dependency check to specifically warn when the uv.lock file is not updated alongside manifest changes.

Comment thread Dangerfile.js
Comment on lines +16 to +17
const hasSourceChanges = danger.git.modified_files
.some(f => f.startsWith("src/"));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The hasSourceChanges check currently only considers modified_files. It should also include created_files to ensure that new source files are also checked for accompanying tests, maintaining consistency with the hasTestChanges check on line 18.

const hasSourceChanges = danger.git.modified_files
  .concat(danger.git.created_files)
  .some(f => f.startsWith("src/"));

Comment thread Dangerfile.js
Comment on lines +59 to +66
const touchedDeps = danger.git.modified_files.filter(f => depFiles.includes(f));

if (touchedDeps.includes("pyproject.toml") || touchedDeps.includes("requirements.txt")) {
warn(
"📦 `pyproject.toml` or `requirements.txt` was modified. " +
"Make sure `uv.lock` is updated (`uv lock`) and the security audit passes."
);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dependency check can be improved by verifying if uv.lock is actually included in the PR when pyproject.toml or requirements.txt are changed. This makes the warning more actionable by only triggering when the lockfile is likely out of sync. Additionally, including created_files ensures the check is comprehensive.

Suggested change
const touchedDeps = danger.git.modified_files.filter(f => depFiles.includes(f));
if (touchedDeps.includes("pyproject.toml") || touchedDeps.includes("requirements.txt")) {
warn(
"📦 `pyproject.toml` or `requirements.txt` was modified. " +
"Make sure `uv.lock` is updated (`uv lock`) and the security audit passes."
);
}
const touchedDeps = danger.git.modified_files
.concat(danger.git.created_files)
.filter(f => depFiles.includes(f));
if ((touchedDeps.includes("pyproject.toml") || touchedDeps.includes("requirements.txt")) && !touchedDeps.includes("uv.lock")) {
warn(
"📦 `pyproject.toml` or `requirements.txt` was modified without updating `uv.lock`. " +
"Please run `uv lock` and include the updated lockfile in your PR."
);
}

@ishaanxgupta ishaanxgupta merged commit 6375883 into main May 17, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant