You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request integrates OpenAI embedding models into the ingestion pipeline, adding support for models like text-embedding-3-small and large. Key changes include a new lazy-loaded OpenAI client, auto-detection of OpenAI models, and logic to handle native dimension reduction and analytics tracking. Review feedback identified a potential AttributeError when tracking token usage if the API response lacks usage data, suggesting a safer way to access these attributes to ensure robustness.
The reason will be displayed to describe this comment to others. Learn more.
Accessing response.usage.total_tokens directly via getattr on response.usage will raise an AttributeError if response.usage is None. While the OpenAI API typically returns usage information, it's safer to handle cases where it might be missing, especially when using OpenAI-compatible proxies or different library versions that might not guarantee the presence of the usage object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.