align portals and shortcuts views with snippets/clipboard-history layout#313
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the Portals and Shortcuts views to use a standardized SplitListDetail layout, improving UI consistency and functionality. Key enhancements include the introduction of shortcut grouping, URL placeholder parsing for portals, and improved error handling via the diagnosticsService. Review feedback suggests minor optimizations, such as removing redundant object spreading and await tick() calls, and consistently using derived state variables instead of direct store access.
| const editingId = editingPortal.id; | ||
| portalStore.update(editingId, portal); | ||
| await removePortalFromIndex(editingId); | ||
| await syncPortalToIndex({ ...portal, id: editingId }); |
There was a problem hiding this comment.
| } else { | ||
| portalStore.add(portal); | ||
| await syncPortalToIndex(portal); | ||
| const idx = portalStore.portals.findIndex(p => p.id === portal.id); |
| context: { message: `Could not index duplicated portal: ${err}` }, | ||
| }); | ||
| } | ||
| await tick(); |
There was a problem hiding this comment.
| }); | ||
| } | ||
| await tick(); | ||
| const idx = portalStore.portals.findIndex(p => p.id === dup.id); |
Xoshbin
added a commit
that referenced
this pull request
May 24, 2026
align portals and shortcuts views with snippets/clipboard-history layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.