Implement clone() and equals() methods for the nullable_T_vector structs #491
Merged
Implement clone() and equals() methods for the nullable_T_vector structs #491
clone() and equals() methods for the nullable_T_vector structs #491Conversation
q10
force-pushed
the
bm-exchange-cpp-2
branch
from
9f0d6c5 to
1d04ca7
Compare
- Add clone() methods to the nullable T vector classes to simplify the code generation - Add unit tests to ensure that the clone methods work correctly
- Rewite the clone operation in GroupingFunction to use the C++ clone() methods to simplify the code generation
q10
force-pushed
the
bm-exchange-cpp-2
branch
from
1d04ca7 to
e055c2d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
NullableScalarVec<T>for consistency of implementationclone()andequals()methods for all thenullable_T_vectorsGroupingFunction.cloneVecStmt()to call the C++ member functions for structcopy().See the example generated code for vastly simplfiied implementation of the exchange function for the zero key case.
The primary goal for this PR is to demonstrate that redefining the nullable scalar vectors as template instantiation of a common template class works. Additional work will follow to fold the rest of the code generated
GroupingFunction.groupDatainto common C++ library code.