Conversation
- Move generic tuple sort to the C++ level using variadic templates and template function recursion
- Update the existing nullable_T_vector hash_at() functions to use int64_t - Implement hash_vec() for nullable_varchar_vector to get back a vector of hash values for each value in the vector - Integrate hash_vec() into the GroupingCodeGenerator
- Update the C++ sort_tuples() function to support DESC sort - Harden the sort_tuples() function to account for 0-length tuples
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
hash_at()functions to useint64_thash_vec()for nullable_varchar_vector to get a vector of hash values for each value in the vector