Skip to content

Implement getter function to get grid directly from multihistogram#32

Merged
XzzX merged 9 commits intoXzzX:mainfrom
J-Hizzle:implement-getter-function-to-get-grid-directly-from-multihistogram
Feb 7, 2025
Merged

Implement getter function to get grid directly from multihistogram#32
XzzX merged 9 commits intoXzzX:mainfrom
J-Hizzle:implement-getter-function-to-get-grid-directly-from-multihistogram

Conversation

@J-Hizzle
Copy link
Copy Markdown
Contributor

@J-Hizzle J-Hizzle commented Jan 31, 2025

Solves #30

Comment thread mrmd/data/MultiHistogram.hpp Outdated
Comment thread mrmd/data/MultiHistogram.hpp Outdated
Comment thread mrmd/data/MultiHistogram.hpp Outdated
Comment thread mrmd/action/ThermodynamicForce.hpp Outdated
@XzzX
Copy link
Copy Markdown
Owner

XzzX commented Feb 4, 2025

We can keep the CPU/GPU getBinPosition.

Copy link
Copy Markdown
Owner

@XzzX XzzX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not duplicate code.

Comment thread mrmd/data/MultiHistogram.hpp Outdated
Comment thread mrmd/data/MultiHistogram.hpp Outdated
@XzzX XzzX enabled auto-merge February 7, 2025 09:48
@XzzX XzzX merged commit a41c018 into XzzX:main Feb 7, 2025
@J-Hizzle J-Hizzle deleted the implement-getter-function-to-get-grid-directly-from-multihistogram branch February 7, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants