[Fix/#130] 루틴 수정 시 수정된 루틴 데이터를 fetch 하도록 수정합니다.#131
Merged
Conversation
WalkthroughRoutineListViewModel에 GetWriteRoutineEventFlowUseCase를 의존성 주입하고, 해당 플로우를 수집해 이벤트가 발생할 때마다 fetchRoutines()를 재호출하도록 observeRoutineChanges()를 추가했으며, 초기 fetch 이후 이를 구독하도록 초기화 로직을 수정했습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as 사용자
participant View as RoutineListViewModel
participant UseCase as GetWriteRoutineEventFlowUseCase
participant Repo as RoutineRepository
Note over View: init 시
View->>Repo: fetchRoutines()
Repo-->>View: Routine 목록 반환
Note over View,UseCase: 변경 이벤트 관찰 시작
UseCase-->>View: WriteRoutine 이벤트 방출
View->>Repo: fetchRoutines()
Repo-->>View: 최신 Routine 목록 반환
View-->>User: UI 상태 업데이트
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
presentation/src/main/java/com/threegap/bitnagil/presentation/routinelist/RoutineListViewModel.kt(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
presentation/src/main/java/com/threegap/bitnagil/presentation/routinelist/RoutineListViewModel.kt (2)
9-9: LGTM!필요한 use case import가 올바르게 추가되었습니다.
28-28: LGTM!의존성 주입이 올바르게 구성되었으며, 기존 패턴과 일관성을 유지하고 있습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ PR Content ]
Related issue
Screenshot 📸
Work Description
To Reviewers 📢
Summary by CodeRabbit