[Feat-T3-67] Apple 로그인 구현 by choijungp · Pull Request #14 · YAPP-Github/Bitnagil-iOS

choijungp · 2025-07-02T06:09:22Z

🌁 Background

소셜 로그인 중 애플 로그인 기능을 구현하였습니다.
AuthenticationServices 프레임워크를 추가하여 Apple 로그인을 진행하였습니다.

📱 Screenshot

Simulator.Screen.Recording.-.iPhone.15.-.2025-07-02.at.14.39.11.mp4

👩‍💻 Contents

LoginViewController에 apple 로그인 버튼 추가
LoginUseCase, AuthRepository에 appleLogin 기능 추가
AuthError 세분화

✅ Testing

이전 카카오 로그인 PR에서 구현한 LoginViewController에 애플 로그인 버튼을 추가하여 테스트를 진행하였습니다.
카카오 로그인과 마찬가지로 Keychain에 서버로부터 받은 토큰 값을 저장한 것까지 테스트 완료하였습니다.

📝 Review Note

Apple 로그인 닉네임

Apple 로그인은 최초 로그인 시에만 닉네임 정보를 가져옵니다.
따라서 애플 로그인 시도 시에 닉네임을 가져왔다면 UserDefaults에 닉네임을 저장하고, 다음 로그인 시도부터 닉네임이 없을 때 저장된 값을 불러와 서버 통신을 시도합니다.
그에 따라 AuthRepository에 UserDefaults 의존성을 추가하였습니다.

LoginViewController에서 Apple authToken 및 닉네임 가져오기

Apple 로그인을 구현할 때 ASAuthorizationControllerDelegate, ASAuthorizationControllerPresentationContextProviding를 채택해서 내부 메서드를 구현해주어야 authToken과 원하는 유저 정보를 가져올 수 있습니다.
ASAuthorizationControllerDelegate은 인증 흐름이 완료되었을 때 성공 및 실패를 받아 처리하는 역할을 하고,
ASAuthorizationControllerPresentationContextProviding은 인증 UI를 어디서 표시할지 알려주는 역할을 합니다.
이때 ASAuthorizationControllerPresentationContextProviding은 UIWindow를 필요로 하고, Repository 단에서 view.window를 접근하기에는 어려움이 있었습니다.

// MARK: - ASAuthorizationControllerPresentationContextProviding
extension LoginViewController: ASAuthorizationControllerPresentationContextProviding {
    public func presentationAnchor(for controller: ASAuthorizationController) -> ASPresentationAnchor {
        return view.window ?? UIWindow()
    }
}

따라서 LoginViewController에 해당 프로토콜들을 채택하고 Apple 인증 성공 시 닉네임, 토큰 값을 전달받아 이후 Repository에서는 서버 통신만을 할 수 있도록 구현하였습니다.
만약 더 좋은 방법이 있다면 알려주세요 ~!

📣 Related Issue

close #T3-67

- ASAuthorizationControllerDelegate, ASAuthorizationControllerPresentationContextProviding 채택해주는 로직 LoginViewController로 이동 (기존 AuthRepository)

- LoginViewModel에서 apple 로그인 결과에 따라 값을 방출할 수 있도록 구현 - LoginUseCaseProtocol, LoginUseCase appleLogin 함수 정의 및 구현

- AuthRepositoryProtocol, AuthRepository appleLogin 정의 및 구현 - 받은 닉네임, 토큰 값을 통해 서버 통신 로직 구현 - UserDefaults에 닉네임 저장 및 불러오는 로직 구현

coderabbitai · 2025-07-02T06:09:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in a Comment
Commit Unit Tests in branch feat/apple-login

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary or @coderabbitai 요약 to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

generalban

오탈자 체크만 해주시면 됩니닷~ 고생하셨어요

generalban · 2025-07-02T08:28:44Z

-        static let loginBottomPadding: CGFloat = 54
+    private enum Layout {
+        static let horizontalMargin: CGFloat = 20
+        static let loginButtonHegiht: CGFloat = 54


사소한 타이포~ Hegiht → Height 오타 수정해주세요

Apple 로그인 구현 수고 많으셨습니다! 사소한 오타(loginButtonHegiht)만 수정해주시면 바로 Approve 드리겠습니다 :)

generalban · 2025-07-02T08:30:45Z

+            try self.saveNickname(nickname: nickname)
+            savedNickname = nickname
+        } else {
+            savedNickname = try self.loadNickname()


그냥 의견일뿐입니다! 수정할거 없습니다! if let + else에서 nickname 값을 한 번 더 리턴하지 않도록 guard let을 써서 early exit 방식도 가능합니닷

넵 ~ 최초 로그인 시에만 닉네임을 저장하고 불러온 닉네임이라면 저장할 필요가 없으니까 if - else를 사용하긴 했습니다.

choijungp added 10 commits July 1, 2025 13:37

Refactor: LoginView Layout Enum 상수값 네이밍 수정

ca99a65

Feat: LoginViewController에 Apple Login 버튼 추가

363d3cf

Fix: TokenResponse, TokenEntity 값 서버에 맞게 수정

967ef2a

Refactor: Apple 로그인 토큰 값 및 유저 정보 가져오는 로직 ViewController로 이동 (#T3-67)

255ad09

- ASAuthorizationControllerDelegate, ASAuthorizationControllerPresentationContextProviding 채택해주는 로직 LoginViewController로 이동 (기존 AuthRepository)

Feat: LoginViewModel, LoginUseCase에 appleLogin 함수 구현 (#T3-67)

4a3049e

- LoginViewModel에서 apple 로그인 결과에 따라 값을 방출할 수 있도록 구현 - LoginUseCaseProtocol, LoginUseCase appleLogin 함수 정의 및 구현

Feat: AuthError 및 UserDefaultsKey Enum 값 정의

7c47267

Refactor: 카카오 로그인 에러 구체화

83a4cf9

Feat: AuthRepository appleLogin 구현 (#T3-67)

ccac622

- AuthRepositoryProtocol, AuthRepository appleLogin 정의 및 구현 - 받은 닉네임, 토큰 값을 통해 서버 통신 로직 구현 - UserDefaults에 닉네임 저장 및 불러오는 로직 구현

Feat: AuthRepository UserDefaults 의존성 추가

5b9fe51

Chore: 프로젝트 세팅에 entitlements 지정

92037fb

choijungp requested a review from generalban July 2, 2025 06:09

choijungp self-assigned this Jul 2, 2025

Chore: 코드래빗 설정 파일 추가

ea0dc1f

generalban approved these changes Jul 3, 2025

View reviewed changes

Refactor: Height 오타 수정

ce84573

choijungp merged commit a9d19eb into develop Jul 3, 2025
2 checks passed

choijungp deleted the feat/apple-login branch July 3, 2025 05:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat-T3-67] Apple 로그인 구현#14

[Feat-T3-67] Apple 로그인 구현#14
choijungp merged 12 commits intodevelopfrom
feat/apple-login

choijungp commented Jul 2, 2025

Uh oh!

coderabbitai Bot commented Jul 2, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

generalban left a comment

Uh oh!

generalban Jul 2, 2025

Uh oh!

generalban Jul 2, 2025

Uh oh!

generalban Jul 2, 2025

Uh oh!

choijungp Jul 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

choijungp commented Jul 2, 2025

🌁 Background

📱 Screenshot

👩‍💻 Contents

✅ Testing

📝 Review Note

📣 Related Issue

Uh oh!

coderabbitai Bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

generalban left a comment

Choose a reason for hiding this comment

Uh oh!

generalban Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

generalban Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

generalban Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

choijungp Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jul 2, 2025 •

edited

Loading