-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: deprecated된 compose-shadow 라이브러리 제거 및 modifier.shadow API 적용 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…difier api 사용 방식으로 전환
Walkthrough더 이상 유지되지 않는 서드파티 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@gradle/libs.versions.toml`:
- Line 79: Remove the unused explicit library declaration named
"androidx-foundation" (the entry that sets foundation = "1.10.1") from
libs.versions.toml and keep the BOM-managed "androidx-compose-foundation" entry;
ensure no references to the removed "androidx-foundation" identifier remain in
the codebase and rely on the existing BOM-managed declaration for the
androidx.compose.foundation artifact.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
feature/screens/build.gradle.ktsfeature/screens/src/main/kotlin/com/ninecraft/booket/feature/screens/component/MainBottomBar.ktgradle/libs.versions.toml
💤 Files with no reviewable changes (1)
- feature/screens/build.gradle.kts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ci-build
- GitHub Check: Compose Stability Check
🔇 Additional comments (2)
gradle/libs.versions.toml (1)
22-22: BOM 버전 확인 완료
dropShadowAPI를 위해 BOM을2025.08.00으로 업데이트한 것이 확인되었습니다. 해당 버전은 Maven 저장소에서 사용 가능하며,dropShadowAPI가 도입된 Compose 1.9.0을 정확히 제공합니다.feature/screens/src/main/kotlin/com/ninecraft/booket/feature/screens/component/MainBottomBar.kt (1)
47-58: Compose FoundationdropShadowAPI로의 마이그레이션이 올바르게 구현되었습니다.
dropShadow모디파이어와Shadow클래스의 사용법이 적절하며, 모든 임포트 문이 올바릅니다. 프로젝트에서 사용 중인 Compose BOM 2025.08.00은dropShadowAPI가 도입된 정확한 버전이므로, API는 안정적으로 지원됩니다.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
seoyoon513
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve~👍👍
🔗 관련 이슈
📙 작업 설명
🧪 테스트 내역 (선택)
📸 스크린샷 또는 시연 영상 (선택)
💬 추가 설명 or 리뷰 포인트 (선택)
Summary by CodeRabbit
Summary by CodeRabbit
릴리스 노트
의존성 업데이트
리팩토링
최적화
✏️ Tip: You can customize this high-level summary in your review settings.