[TNT-142] 트레이니 연결 화면 작성 완료 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FpRaArNkK
force-pushed
the
TNT-142-traineeSignUp-connectionSecond
branch
from
e1d1d5f to
552bc1b
Compare
syss220211
reviewed
Jan 29, 2025
Member
There was a problem hiding this comment.
Entity면 객체네이밍 끝에 Entity라고 붙이는거 어떨까요?
Contributor
Author
There was a problem hiding this comment.
네 좋아요! 반영해놓겠습니다 :)
Comment on lines
20
to
22
| func verifyTrainerInvitationCode(_ code: String) async throws -> Bool | ||
| /// API Call - 트레이니 - 트레이너 연결 API 호출 | ||
| func connectTrainer(_ info: TraineeConnectInfo) async throws -> ConnectionInfo |
Member
There was a problem hiding this comment.
이 부분 저희 상의한대로 Repo로 빼면 될것같습니다! 이외의 모든 DefaultUseCase도 반영 부탁드려요!
Contributor
Author
There was a problem hiding this comment.
넵 확인입니다 반영해놓을게요!
작업 순서 문제로 추후에 추가 PR 작성해서 올리겠습니다!
syss220211
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 What is the PR?
🪄 Changes
🌐 Common Changes
🔥 PR Point
전에 작성했던대로, DIContainer를 활용한 UseCase 사용방식 그대로 Trainee Repository, Usecase를 작성했습니다.
추후 추가 작성 필요시 그대로 작업해주시면 될 것 같습니다.
작성 화면 중 겹치는 화면들은 UserType을 넣으면 해당 타입 기능이 수행될 수 있게 작성했습니다.
반영하시면 좋을 것 같아요.
💭 Related Issues