Abstracted expanding button component #516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the timetable expansion logic by introducing a new reusable
ExpandingButtoncomponent and updating theEventTimetablecomponent to work with it. This change improves code modularity and accessibility, making the timetable expansion more flexible and easier to maintain.Component Refactoring and Reusability:
ExpandingButtoncomponent (expanding-button.ce.vue) that encapsulates the expand/collapse button and its associated content, with proper accessibility attributes and slot support for custom content.ExpandingButtoncomponent and added a Storybook story for documentation and testing. [1] [2]Integration and API Changes:
SocialSportPageto use the newExpandingButtonfor the timetable, passing the expanded state toEventTimetablevia theis-visibleprop. [1] [2]EventTimetablecomponent to remove its own expand/collapse button and related logic, and replaced theisExpandedstate and prop withisVisible, which is now controlled by the parent component. All relevant tabindex bindings now useisVisibleinstead ofisExpanded. [1] [2] [3] [4] [5] [6] [7] [8]Behavior and Accessibility Improvements:
Checklist
main).