Removed redirect after voting #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| setTimeout(() => { | ||
| window.location.assign("/elections"); | ||
| }, 3500); | ||
| console.log("Vote submitted successfully"); |
There was a problem hiding this comment.
Bug: After a vote is submitted, the component state is not cleared and no success feedback is shown, allowing the user to immediately resubmit the same vote.
Severity: HIGH
Suggested Fix
In the .then() block of the submitVotes function, add logic to provide clear success feedback to the user. This could involve displaying a success message, clearing the component's state by calling this.clearVotes(), and/or redirecting the user to a confirmation page, similar to the previous behavior.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/components/elections-vote/elections-vote.ce.vue#L375
Potential issue: After a user successfully submits a vote via the `submitVotes`
function, the component's state is not cleared, and no visual feedback is provided to
the user. The previous redirect logic was removed but not replaced. As a result, the
submission modal closes after a timeout, returning the user to the voting page with
their previous selections still active and all buttons re-enabled. This can lead to user
confusion about whether the vote was successful and allows them to immediately resubmit
the same vote.
Did we get this right? 👍 / 👎 to inform future reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes a small change to the vote submission logic in the
elections-vote.ce.vuecomponent. Instead of redirecting the user to the elections page after submitting a vote or spoiled vote, it now logs a message to the console indicating successful submission./electionswith a console log message upon successful vote or spoiled vote submission inelections-vote.ce.vue. [1] [2]Checklist
main).