Skip to content

Conversation

@bbb651
Copy link
Contributor

@bbb651 bbb651 commented Apr 21, 2025

@billksun
Copy link
Contributor

This PR may fix an issue with running COSMIC on niri: Drakulix/cosmic-ext-extra-sessions#12 (comment)

@YaLTeR YaLTeR force-pushed the ext-foreign-toplevel-handle branch from 0e64bad to b9c08ab Compare June 10, 2025 15:09
@YaLTeR
Copy link
Owner

YaLTeR commented Jun 10, 2025

This should be good to merge now. Is there any bar to test the dynamic updating of the list? One of the problems I just fixed was missing send_done().

@sodiboo
Copy link
Contributor

sodiboo commented Jul 14, 2025

We already have an implementation of wlr-foreign-toplevel-manager in src/protocols/foreign_toplevel.rs, which is conceptually a very similar protocol. Would it be better to pair these, augmenting that file to support both protocols? It's fairly straightforward to do so, sodiboo@d2d51bc still cleanly applies to the main branch. This way, the general behaviour between both protocols will be more consistent and there's only one "manager" type in the niri codebase to deal with.

@YaLTeR
Copy link
Owner

YaLTeR commented Jul 15, 2025

Sounds like a good idea actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants