refactor(cli): ♻️ separate UI logic into dedicated module#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
This PR executes a significant architectural refactoring of the CLI commands. It separates the business logic and orchestration from the UI logic (user prompts and console logging) by introducing a dedicated UI module located at
packages/cli/src/ui.ts.This change dramatically improves code quality, testability, and maintainability by adhering to the Single Responsibility Principle. Command files are now cleaner and focused on what to do, while the
ui.tsmodule handles how to interact with the user.🔗 Related Issue
Fixes #25
🧪 Type of Change
📝 How Has This Been Tested?
init,generate,git,release, andconfigto verify that the refactored UI prompts and logs behave identically to the previous implementation.buildandtestjobs complete successfully.✅ Checklist
🔄 Dependencies
None.
📚 Additional Notes
This refactoring significantly improves the testability of the CLI commands. Future unit tests can now mock the
ui.tsmodule as a whole, rather than mockinginquirerandconsole.logindividually, leading to cleaner and more robust tests.Issue Reference: Closes #25