-
Notifications
You must be signed in to change notification settings - Fork 10
Fix user check for jira ticketing #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| USER_BATCH = 'batch' # used by batch servers | ||
| USER_TRON = 'TRON' # used by Tron jobs, or other paasta CLI commands such as `paasta validate/mark-for-deployment` | ||
| USER_UNSPECIFIED = 'UNSPECIFIED' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TICKET_NOT_REQUIRED_USERS = {
'batch', # non-human spark-run from batch boxes
'TRON', # tronjobs that run commands like paasta mark-for-deployment
None, # placeholder for being unable to determine user
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, I think this makes my next question a lot clearer: do we need to add UNSPECIFIED to this set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for keeping the user pod label spark.yelp.com/user for the metrics / pod search, specific to _get_k8s_spark_env(). I changed the constant name to USER_LABEL_UNSPECIFIED for clarification
|
How do we verify that this fixes the issue for |
bdad6c6 to
5f0095a
Compare
Perhaps @nemacysts will have a better idea. On the other hand, I think if |
64ec8b6 to
add8d63
Compare
Problem
paasta CLI commands such as
paasta validate,paasta mark-for-deploymentare blocked by the jira ticket check since they call theget_spark_configwhile trying the build the Tron configs.More details in: https://github.yelpcorp.com/sysgit/srv-configs/pull/44869
Solution
Use the
userexplicitly passed from get_spark_conf parameters for jira ticketing check, instead of reading from environment variables.Test