Fix StopIteration runtime error for py37 above#7
Merged
gstarnberger merged 1 commit intoYelp:masterfrom Jul 25, 2023
Merged
Conversation
gstarnberger
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We got error
RuntimeError: generator raised StopIterationfor several integration tests in schematizer fromsqlparse, which due to a change in Python https://peps.python.org/pep-0479/I just apply the same change that had been done in upstream to fix this issue andialbrecht#202, I hope this can fix the errors.
###Note to reviewer
For this PR I can't add reviewers and assignees bc I don't have write access to the repo. I checked the previous PRs, it seemed to be the same case, so tagging @mhaseebmlk and @gstarnberger (ppl i can find under github yelpcorp) for review