fix(FormManager): use constante from ImageField#1182
Merged
mrflos merged 1 commit intoYesWiki:doryphore-devfrom Jul 19, 2024
Merged
fix(FormManager): use constante from ImageField#1182mrflos merged 1 commit intoYesWiki:doryphore-devfrom
mrflos merged 1 commit intoYesWiki:doryphore-devfrom
Conversation
Contributor
|
Plutot que de rendre publique la propriété, c'est pas plus simple de faire des |
Contributor
Author
|
En fait, le code qui utilise cette constante est située dans |
Contributor
|
Ok j'avais pas vu que c'était dans une autre classe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent commit (4cede2f) seems to have introduced errors in FormManager (usage of
$this::to access to a constant instead ofself::).What do this PR:
publicthe constantFIELD_IMAGE_DEFAULTinImageFieldFormManagerHow to test: