fix(deps): drop hard marketplace pin on web-design dep#14
Merged
Conversation
…> 0.1.3 When ytstack is cross-listed in ystacks-internal, the hard `marketplace: "ystacks"` pin on web-design breaks dep resolution for users who only added ystacks-internal as a marketplace -- even though web-design is also cross-listed there. Drop the qualifier so the resolver falls back to the marketplace ytstack itself was installed from. yesterday-brand keeps its qualifier (no cross-listing in ystacks). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marketplace: "ystacks"qualifier on theweb-designdependency in.claude-plugin/plugin.jsonso the resolver can fall back to whichever marketplaceytstackitself was installed from.0.1.2->0.1.3inplugin.jsonandmarketplace.jsonso/plugin updateactually picks up the change.yesterday-brandkeeps its qualifier -- it has no cross-listing inystacksand staysystacks-internal-only.Why
Reported by user:
/doctorerrors on a fresh install ofytstack-internal@ystacks-internal-- the bundle pulls inytstack(cross-listed inystacks-internal), butytstack's ownplugin.jsonhard-pinsweb-design@ystacks. Even thoughweb-designis cross-listed inystacks-internaltoo, the explicitmarketplacequalifier blocks fallback. Result:web-designunresolvable ->ytstackdisabled ->ytstack-internaldisabled. The user's expected flow is "installytstack-internal, get everything", without manually adding the publicystacksmarketplace.Test plan
/plugin update ytstack-internal@ystacks-internalafter merge/doctorreports no plugin errors forytstackorytstack-internalclaude plugin install ytstack@ystacksin a clean profile ->web-designresolved fromystacksclaude plugin install ytstack-internal@ystacks-internalin a clean profile (noystacksadded) ->web-designresolved fromystacks-internalcross-listingNotes for reviewer
🤖 Generated with Claude Code
Note
Low Risk
Low risk metadata-only change: relaxes dependency resolution for
web-designand bumps plugin version, with no runtime code changes. Main risk is unexpected resolver behavior across marketplaces causing install/update resolution differences.Overview
Removes the explicit
marketplace: "ystacks"qualifier from theweb-designdependency in.claude-plugin/plugin.json, allowing dependency resolution to follow the marketplaceytstackwas installed from.Bumps the plugin version from
0.1.2to0.1.3in both.claude-plugin/plugin.jsonand.claude-plugin/marketplace.jsonso updates pick up the dependency metadata change.Reviewed by Cursor Bugbot for commit 0e673c8. Bugbot is set up for automated code reviews on this repo. Configure here.