Merged
Conversation
Old implementation didn't work, it would crash when it tried to dereference and set a null pointer (*x = i). This version works by setting the default size to destinationSize, so it will throw in the later check if no \0 is found. This function is otherwise unused in the code.
Windows doesn't respect the openssl standard, so that needed to be handled manuall. Since this project uses a statically linked openssl, the default locations may be inaccurate. If that directory doesn't exist, it tries to get it from the system openssl via a popen. If that also fails, it will not be able to load system certs.
…ta to the callback. This was necessary to get a handle on the agent during the connection callback.
This will cause the connection to fail if the value is set and the agent attempts to connect to a server with an invalid web certificate
Before it would override any user defined checks; now it will foil to connect if the system certs don't match, but will still run user checks if it passes those.
This will cause rejectUnauthorized to be true if you pass it in
…on and use rejectUnauthorized if it is set.
Contributor
Author
|
@Ylianst , Can I get a description of what would need to be implemented in order for this or something that accomplishes this effect to be merged? |
Owner
|
I will take this, but please don't add
The goal of the agent was to connect to the server with minimal dependency on the system's configuration and deal with situation where DNS is not available, etc. It's ok to add this check, but at the administrator's own risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to have the agent validate the webcert of the server to which it is connected. This is valuable in the case of a DNS hijack or MITM, which currently is possible if a bad actor can gain access to the meshcentral agent cert, and that cert can't be rotated or expired.
This is accomplished by adding
validateWebCert=truein the msh file. It will continue to run as normal until such time as that value is set.Once this is gone over, I will create a PR in the Meshcentral repo to update the meshcore and add a config option to have this option set on your agents by default.