Skip to content

Refactor assets enqueing hooks and callbacks#21837

Draft
enricobattocchi wants to merge 1 commit intotrunkfrom
iframed-editor-enqueues
Draft

Refactor assets enqueing hooks and callbacks#21837
enricobattocchi wants to merge 1 commit intotrunkfrom
iframed-editor-enqueues

Conversation

@enricobattocchi
Copy link
Member

(cherry picked from commit dd80d2d)

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a console notice in WordPress 6.7 about wrong enqueuing of assets in the iframed editor.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/1868

@enricobattocchi enricobattocchi added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Nov 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2ee56b565f92ded45e7dd80bdb9758da02f7ce38

Details

  • 2 of 11 (18.18%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 54.677%

Changes Missing Coverage Covered Lines Changed/Added Lines %
admin/metabox/class-metabox.php 2 11 18.18%
Files with Coverage Reduction New Missed Lines %
admin/metabox/class-metabox.php 6 20.4%
Totals Coverage Status
Change from base Build 3b484c3d2b5ef01ce4e5a53c71a2e7b896f92b19: -0.01%
Covered Lines: 29747
Relevant Lines: 54698

💛 - Coveralls

@github-actions
Copy link

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog merge conflict

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants