Skip to content

Make score endpoints work in plain permalinks#21863

Merged
igorschoester merged 2 commits intofeature/dash-phase-1from
535-make-score-endpoints-work-in-plain-permalinks
Nov 27, 2024
Merged

Make score endpoints work in plain permalinks#21863
igorschoester merged 2 commits intofeature/dash-phase-1from
535-make-score-endpoints-work-in-plain-permalinks

Conversation

@leonidasmi
Copy link
Contributor

@leonidasmi leonidasmi commented Nov 26, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where the dashboard widgets wouldnt work when permalinks where set to plain.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Confirm that the dashboard widgets work both for seo scores and readability scores
  • Confirm that filtering the scores by taxonomy works as expected
  • Go to Settings->Permalink, set Plain as your site's permalinks and repeat the test above

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/roadmap/issues/535

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 26, 2024
@leonidasmi leonidasmi added this to the feature/dash-phase-1 milestone Nov 26, 2024
@coveralls
Copy link

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build b7f8e039ea56db6f5ed5516a8af8c38a1f274509

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 10 (0.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 54.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/dashboard/scores/components/scores.js 0 5 0.0%
packages/js/src/dashboard/scores/components/term-filter.js 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/dashboard/scores/components/scores.js 4 0.0%
Totals Coverage Status
Change from base Build 851d976ec099eebb3913b4f92b2c01b10b74db72: -0.004%
Covered Lines: 29764
Relevant Lines: 55301

💛 - Coveralls

Copy link
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ❓

Nice catch!
Now that I see your code, I'm thinking that can be simplified. Can it? 😇

Copy link
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

Subdomain site also likes it 👍

@igorschoester igorschoester merged commit 20cac14 into feature/dash-phase-1 Nov 27, 2024
@igorschoester igorschoester deleted the 535-make-score-endpoints-work-in-plain-permalinks branch November 27, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants