Skip to content

Comments

Open the CTA in a new tab if parentTaskID is available#23005

Merged
leonidasmi merged 4 commits intofeature/task-list-phase-2from
1077-task-list-make-the-cta-of-child-tasks-open-in-a-new-tab
Feb 20, 2026
Merged

Open the CTA in a new tab if parentTaskID is available#23005
leonidasmi merged 4 commits intofeature/task-list-phase-2from
1077-task-list-make-the-cta-of-child-tasks-open-in-a-new-tab

Conversation

@FAMarfuaty
Copy link
Contributor

@FAMarfuaty FAMarfuaty commented Feb 19, 2026

Context

Summary

This PR can be summarized in the following changelog entry:

  • Makes the CTA of tasks with "link" or "add" buttons opened in a new tab when clicked.

Relevant technical choices:

  • We no longer have to check if the CTA points to the same page and to reload if we do for tracking purposes, because opening in a new tab will actually track the action, so we simplified the implementation there.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install and activate Yoast SEO
  • We're changing all CTA links, even in older tasks, to make them open a new tab when clicked
  • So, in a fresh site with ALL tasks as incomplete, go to the task list
  • For the new tasks, follow the following instructions:
    • Create some posts or pages with a keyphrase set
    • Make sure that they have bad score for SEO and Readability analysis
    • Go to Task list: Yoast SEO > General > Task list
    • Open the Improve the readability of your recent content task: your post/page with a bad readability score should be visible as its child task
    • Click on the content title to open the child task
    • Click on Open editor button
    • Confirm that a new tab is opened and you are taken to the editor for your content
    • Open the Improve the SEO of your recent content task: your post/page with a bad SEO score should be visible as its child task
    • Click on the content title to open the child task
    • Click on Open editor button
    • Confirm that a new tab is opened and you are taken to the editor for your content
  • For every old task (except the Enable llms.txt and Delete Hello World tasks, which are special because their CTAs don't redirect you to any page, but rather perform an action under the hood), click on its CTA and confirm that you get a redirected in a new tab in the page that you are supposed to
  • For the Enable llms.txt and Delete Hello World tasks, click on their CTAs and confirm that:
    • you're not opening a new tab
    • the buttons get their loading state until the task gets completed

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@FAMarfuaty FAMarfuaty added this to the feature/task-list-phase-2 milestone Feb 19, 2026
@FAMarfuaty FAMarfuaty added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 19, 2026
@FAMarfuaty FAMarfuaty marked this pull request as ready for review February 19, 2026 10:54
@coveralls
Copy link

coveralls commented Feb 19, 2026

Pull Request Test Coverage Report for Build a593b8b9c32938423e500fa1c99e83e320becd67

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 53.572%

Files with Coverage Reduction New Missed Lines %
packages/js/src/settings/site-features/ai-tools.js 1 0.0%
packages/js/src/introductions/initialize.js 15 0.0%
Totals Coverage Status
Change from base Build 741c11379f1f4f74b03f54d1b8b63454f347a31b: -0.007%
Covered Lines: 33191
Relevant Lines: 62148

💛 - Coveralls

@leonidasmi leonidasmi mentioned this pull request Feb 20, 2026
19 tasks
Copy link
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance is ✅

@leonidasmi leonidasmi merged commit c8c989a into feature/task-list-phase-2 Feb 20, 2026
21 checks passed
@leonidasmi leonidasmi deleted the 1077-task-list-make-the-cta-of-child-tasks-open-in-a-new-tab branch February 20, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants