Fix article enhancer

[pls78]

Context

• We want to fix the article enhancer

Summary

This PR can be summarized in the following changelog entry:

• Fixes a bug where categories were not added to the Article keywords when the keywords array was not empty.

Relevant technical choices:

• I removed the piece of code that adds tags to the keywords property because our Article Schema piece already has them

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Test the article enhancer

• Edit a post
• Assign one or more categories to it
• Assign also some tags
• Hit the wp-json/yoast/v1/schema-aggregator/get-schema/post endpoint
  • Verify the Article related to your post has only the tags in the keywords property
• Add the following code to your blog:

  add_filter( 'wpseo_article_enhance_config_categories_as_keywords', '__return_true' );
  

• Hit the wp-json/yoast/v1/schema-aggregator/get-schema/post endpoint again (clear the cache)
  • Verify the Article related to your post now has the also the associated categories in the keywords property
• Remove the filter code and verify the categories are now gone

Test the author enhancer

• Follow the updated instructions here

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• N/A

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
• This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added updated unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.
• I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2864

[thijsoo]

CR + ACC 👍