Skip to content

Update the suggestion in the content suggestion state#23201

Merged
thijsoo merged 3 commits intofeature/content-plannerfrom
1178-content-planner-update-title-and-meta-description-changes-the-in-the-content-suggestion
Apr 28, 2026
Merged

Update the suggestion in the content suggestion state#23201
thijsoo merged 3 commits intofeature/content-plannerfrom
1178-content-planner-update-title-and-meta-description-changes-the-in-the-content-suggestion

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Apr 28, 2026

Context

Summary

This PR can be summarized in the following changelog entry:

  • Updated the suggestion title in the content suggestion modal after modification in the content outline modal.
  • Restores focus to the content suggestions modal after going back to the list of suggestions.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • In a new post click on the Get content suggestions button.
  • When suggestions are generated click on the first one and generate the outline.
  • Once outline is generated, edit the title, keyphrase, meta description and outline and click on Content suggestions button to go back to the list of suggestions.
  • Check the focus is back on the close button.
  • Check the title in the suggestion is updated with the changes.
  • Click the same suggestion and check the changes you made are still there.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Content planner: update title and meta description changes the in the content suggestion

@vraja-pro vraja-pro added this to the feature/content-planner milestone Apr 28, 2026
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 28, 2026
This is done to have one source of truth for the suggestion.
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 28, 2026

Coverage Report for CI Build 0

Coverage decreased (-0.002%) to 53.473%

Details

  • Coverage decreased (-0.002%) from the base build.
  • Patch coverage: 14 uncovered changes across 4 files (4 of 18 lines covered, 22.22%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
packages/js/src/ai-content-planner/store/content-outline.js 7 0 0.0%
packages/js/src/ai-content-planner/store/content-suggestions.js 4 0 0.0%
packages/js/src/ai-content-planner/containers/outline-modal-content.js 3 1 33.33%
packages/js/src/ai-content-planner/hooks/use-fetch-content-outline.js 1 0 0.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
packages/js/src/ai-content-planner/containers/outline-modal-content.js 1 66.67%

Coverage Stats

Coverage Status
Relevant Lines: 66030
Covered Lines: 35173
Line Coverage: 53.27%
Relevant Branches: 16931
Covered Branches: 9189
Branch Coverage: 54.27%
Branches in Coverage %: Yes
Coverage Strength: 45556.69 hits per line

💛 - Coveralls

We want to keep the focus in the modal when going back to suggestions.
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 CR + ACC

@thijsoo thijsoo merged commit 27d511e into feature/content-planner Apr 28, 2026
20 checks passed
@thijsoo thijsoo deleted the 1178-content-planner-update-title-and-meta-description-changes-the-in-the-content-suggestion branch April 28, 2026 11:19
@vraja-pro vraja-pro mentioned this pull request Apr 28, 2026
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants