Fixes for build contract when not running in our docker:dind image#69
Open
Fixes for build contract when not running in our docker:dind image#69
Conversation
Dependabot bumped npm from 6.14.18 to 11.6.4 (e593e9f) as part of a form-data security fix, but npm removed its programmatic API in v8. build-contract-predockerbuild uses require('npm') which breaks with v8+. Pin to ~6.14.18 so dependabot can only bump within 6.14.x. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
docker-compose (standalone binary) is not installed on modern systems. Use docker compose (v2 plugin) which is the standard since Docker 23. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
solsson
changed the title
solsson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had accidentally accepted an npm lib upgrade through #63 which breaks our API use. Also new docker CE installs (on Ubuntu for example) don't have the docker-compose CLI.