ci(e2e-release): trigger on CI completion, not release: published#14
Merged
ci(e2e-release): trigger on CI completion, not release: published#14
Conversation
Every release fired a failed e2e-release run before the assets existed (e.g. run 25228614874 on v0.3.5). The cause is that GitHub fires `release: published` the moment the Release object becomes published -- which, when a maintainer creates the release via the UI before pushing the tag (or in parallel), is BEFORE the CI workflow's release-assets job has uploaded any binaries. The e2e-release validator races in, finds nothing, and fails with "no assets to download". Switching the trigger to `workflow_run` on the upstream `CI` workflow's completion eliminates the race: by the time CI finishes successfully, release-assets has run and the binaries + checksums are attached. The job-level `if:` filters to successful CI runs that came from a tag push (head_branch starting with `v`), so PR/main runs of CI don't trigger an empty validation pass. `workflow_dispatch` with a tag input is preserved for ad-hoc re-runs against any published tag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.