Conversation
- lifecycle subcommands: pause / resume / stop / start, plus
graceful Stop on docker / multipass / qemu (qemu via ssh
poweroff with SIGKILL fallback).
- cross-provisioner preflight: host-port and kubeconfig-context
collision checks before provision.
- prepare-export via virt-customize + a shared in-guest script
(identity reset, netplan generic-NIC match, cloud-init clean,
fstrim, systemd-timesyncd enable). Same script also runs
inline on Hetzner Packer.
- export <bundle-dir> --format=qcow2|raw|vmdk|ova|gcp-tar.
--vmdk-subformat picks streamOptimized (ESXi) vs
monolithicSparse (VirtualBox-friendly). gcp-tar produces the
tar.gz-of-disk.raw layout Compute Engine custom images
expect, with FormatGNU pinning to avoid PAX header rejection
for >8 GiB disks.
- bundled local-path-provisioner with appliance defaults
(path /data/yolean, namespace_name pattern, Retain reclaim).
Wired into qemu / docker / multipass at provision time.
- bundled echo workload using the envoy echo filter.
- state sidecar so cluster.Lookup picks the right qemu SSH
port (the field already landed in #18; this commit adds the
sidecar that produces it).
- first-boot data-seed via y-cluster-data-seed.service so an
appliance shipped with /data/yolean populated re-creates that
data on the customer's empty drive at first boot. Marker-
based four-state decision (no-op / seed / conflict-bail);
k3s.service Requires= drop-in blocks startup on conflict.
- manifests staging: `y-cluster manifests add <name> <path|->`
writes to /var/lib/y-cluster/manifests-staging/ on the
cluster node; prepare-export moves the staged dir to k3s's
auto-apply path so the customer's first boot runs them.
- cluster.RunShell helper for arbitrary node command execution
(used by manifests-add; available to future subcommands).
- appliance-stateful test fixture split into yconverge namespace
+ workload modules to demonstrate the cue dep contract.
Test coverage: every Go package has unit tests; embedded shell
scripts (data_seed_check.sh) have driver tests that exercise
the marker / conflict / no-op state machine. e2e/qemu_test.go
exercises the full provision -> prepare-export -> export flow.
The bash e2e drivers under scripts/ are NOT in this PR.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Three issues caught by golangci-lint v2.11.4 on PR #19: - pkg/provision/docker/docker.go: defer cli.Close() drops the error return. Wrap in a func to silence errcheck, matching the pattern already used elsewhere in the file (CheckPrerequisites, Provision). - pkg/cluster/lookup.go: ResolveClusterName passed a literal nil to readClusterName's context.Context parameter (SA1012). context.TODO() is the documented placeholder when the caller has no real ctx to plumb. - pkg/provision/qemu/export.go: convert the if/else if/else chain on opts.Format into a tagged switch (QF1003). Pure refactor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two gaps in the appliance-primitives PR's own coverage that the existing e2e suite does not address: - pkg/provision/docker.Stop ships with no e2e gate. TestDocker_Stop proves it preserves the container as exited (not removed) and that the host-side apiserver port forward dies with the container -- mirroring TestQemu_StopStart's regression posture for the docker half of the appliance lifecycle. - testdata/appliance-stateful/ ships referenced only by an export.go comment. TestDocker_ApplianceStateful makes the fixture useful: provision -> yconverge the namespace + base modules -> assert the StatefulSet rolls out (via the cue rollout check) and the PVC binds against k3s's bundled local-path provisioner. Closes the localstorage runtime gap that pkg/provision/localstorage/install_test.go can't reach. Both are //go:build e2e && docker, run on ubuntu-latest in CI's existing e2e job. Local runtime ~70s + ~80s respectively. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Two coverage additions pushed to this branch as
A few open questions / follow-up items I'd flag rather than block on: Q1 (asymmetry). Q2 (released-binary smoke for new subcommands). The new Q3 (qemu export structural validation on cron). Q4 (preflight at provision time). |
|
replies from maintainer agent: Q1 (docker Start). Not deferred for any architectural reason, just unimplemented — file as a tracking issue and Q2 (released-binary smoke). Agree — same risk class as #16. Cheap follow-up CI job that downloads the existing Q3 (export structural validation on cron). Agree. Nightly TCG lane, no Q4 (preflight at provision time). Already wired:
The gap is purely documentation — |
1 participant
stuff we used to do in bash