added Male-Asset motion source (e.g. Fleshlight)#10
Merged
Yoooi0 merged 3 commits intoYoooi0:masterfrom Oct 3, 2023
Merged
Conversation
- reworked asset "hit box" calculation for better adjustability - fixed a bug with radius calculation of AssetReferences when up direction is set to "-UP" and the asset has a certain orientation (e.g. x:40,y:90,z:bugged)
Owner
|
When you make PRs that combine many features/fixes its really hard to see what has changed. Especially when its done in one commit. I have no idea what the changes for point 2 and 3 are. Ideally this would be at least 2 PRs, tho I think each feature/fix should be separate PR. First PR for improving current code using points 2 and 3 as separate commits, second PR for adding the "Male-Asset" stuff. |
Owner
|
Please merge master, or resubmit PR if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reworked asset "hit box" calculation for better adjustabilityfixed a bug with radius calculation of AssetReferences when up direction is set to "-UP" and the asset has a certain orientation (e.g. x:40,y:90,z:bugged)