Respect standard proxy header for hostname when generating M3U playlist#611
Merged
tsynik merged 2 commits intoYouROK:masterfrom Dec 29, 2025
Merged
Respect standard proxy header for hostname when generating M3U playlist#611tsynik merged 2 commits intoYouROK:masterfrom
tsynik merged 2 commits intoYouROK:masterfrom
Conversation
Rely on Gin's location middleware for retrieval of host/port combination, so that HTTP headers (such as ones passed from a reverse proxy) are also taken into account. Only `/stream` API seems to be relevant for YouROK#610 (see web's Hosts.js) but fix `/playlist*` APIs as well while we're at it. It seems that Media Station X stuff (`msx.go`) may benefit from this too but keep it intact for now as it's offtopic.
Respect standard proxy host header (`X-Forwarded-Host`) when building playlist content. See gin-contrib/location#15 Closes YouROK#610
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #610
First commit makes preparations, with no effective change, whereas the 2nd has the actual fix.
This is my first exposure to Go, so pardon me for not writing any tests 🥺
Manual testing done:
Default address — playlist entries point to the proper address 🟢
Pretend we are behind a reverse proxy — playlist entries point to the proper address 🟢
For comparison, at 28f4f94 (current
master) — playlist entries point to the proper schema 🟢 but wrong address 🔴