[Portugal] Sea routes and towns fix#131
Merged
YourDeveloperFriend merged 5 commits intoYourDeveloperFriend:mainfrom Jul 19, 2025
Merged
[Portugal] Sea routes and towns fix#131YourDeveloperFriend merged 5 commits intoYourDeveloperFriend:mainfrom
YourDeveloperFriend merged 5 commits intoYourDeveloperFriend:mainfrom
Conversation
Owner
|
Sorry, I know I have been putting this off. Ideally, this logic should be contained in a module and reusable, because we now have multiple maps that exhibit this behavior and I don't want to keep duplicating it. Heavy Cardboard and Denmark both do something similar. Can you look at those and see if we can consolidate? |
Contributor
Author
|
Sure, will check next week most likely. Potentially will open new PR and close this one. |
Contributor
Author
|
Actually, would you mind merging this one for the time being? We have a game that's stalled because of it. |
YourDeveloperFriend
approved these changes
Jul 19, 2025
8c3bab9
into
YourDeveloperFriend:main
1 of 2 checks passed
Contributor
Author
|
Thanks, appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, so that was a bit of a pain to fix as it goes against quite a few established rules.
Basically during a playthrough in my group some people instinctively assumed that you wouldn't need to have urbanized Sines or Sagres to establish a sea connection through them to Madeira or Lisboa. After some research it actually turned out (quite surprisingly) to be true.
Details are in the lengthy exchange here. In that thread it has been explicitly stated by both the publisher AND the designer to be true.
What needed to be overwritten was:
a) possibility to build towards an unpassable edge for those 2 locations;
b) possibility to move goods through respective connections;
c) making sure the track to an unpassable edge won't dangle on next build phase end;
Still looks a bit off on the UI side but I'm not sure if much can be done about it.