Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rminvocations that are semantically equivalent torm -rf /but use different flags or argument forms.Description
pkg/tools/shell.gofrom a narrowrm -rf /match to a broader pattern that catchesrm ... /forms targeting the root path, and updated the guard message toremoving root path / is forbidden.denyPatternsandallowPatternscase-insensitive by compiling patterns with(?i)and preallocated the slices usinglen(cfg.*)capacity; ensuredallowPatternsare created and used inNewExecTool.applyRiskGateand movedgit cleaninto destructive patterns inpkg/tools/risk.gosogit cleanis treated as destructive.pkg/tools/shell_test.go, includingTestGuardCommand_BlocksRootWipeVariantsand other tests verifying allow/deny case insensitivity and risk-gate behavior.Testing
go test ./pkg/tools -run 'TestGuardCommand_BlocksRootWipeVariants|TestGuardCommand_DenylistIsCaseInsensitive' -vand the selected tests passed.go test ./pkg/tools -vandgo test ./...and they passed for tested packages.go vet ./...and concurrency checks withgo test -race ./..., which completed without failures.Codex Task