Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
saveStoreerrors.nextSleepDuration(now time.Time)deterministic by respecting the providednowargument, which fixes a semantics mismatch and improves testability.Description
lastSaveError stringtoCronServiceto hold the most recentsaveStoreerror.saveStoreerrors (checkJobs,removeJobUnsafe,EnableJob) to set or clearlastSaveErrorbased on the result ofsaveStore.lastSaveErrorinCronService.Status()to make persistence failures observable via the status API.nextSleepDuration(now time.Time)to compute sleep usingtime.UnixMilli(*nextWake).Sub(now)and addTestNextSleepDuration_UsesProvidedNowto ensure the function uses the provided time argument.Testing
gofmt -w pkg/cron/service.go pkg/cron/service_test.goto normalize formatting and ensure no gofmt issues. (succeeded.)go test ./pkg/cron ./pkg/configwhich passed for the cron package. (succeeded.)go test ./...to validate the full test suite for packages in the repo, which completed successfully for the tested packages. (succeeded.)Codex Task