Skip to content

Fix API dependency declarations #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2019
Merged

Fix API dependency declarations #38

merged 4 commits into from
Oct 2, 2019

Conversation

@emlun
Copy link
Member

@emlun emlun commented Sep 30, 2019

Fixes most of #36.

@emlun
Bump com.upokecenter:cbor dependency to version 3.6.0
35d43b4 
This might resolve some dependency convergence issues detected by Maven
Enforcer; see #36
@emlun
Add subprojects that test dependency declarations
3047c4c 
Exposes issues brought up in issue #36:
#36
@emlun
Expose API dependencies to dependent projects
2f18bab
@emlun emlun requested a review from aveenismail September 30, 2019 14:53
@emlun emlun self-assigned this Sep 30, 2019
@emlun emlun added the bug Something isn't working label Sep 30, 2019
@coveralls
Copy link

coveralls commented Sep 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 319

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 93.333%
Totals Coverage Status
Change from base Build 310: 0.3%
Covered Lines: 630
Relevant Lines: 675
💛 - Coveralls

@emlun emlun merged commit 47d0c4a into master Oct 2, 2019
@emlun emlun deleted the api-deps branch October 2, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aveenismail aveenismail Awaiting requested review from aveenismail

Assignees

@emlun emlun

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emlun @coveralls