Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for the newly introduced FIDO MDS attachment hint value smart-card so upstream metadata BLOBs can be deserialized without throwing an InvalidFormatException.
Changes:
- Add
ATTACHMENT_HINT_SMART_CARDenum constant mapped to JSON string"smart-card"(bit flag0x0200).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! This is now incorporated into #469 and available in experimental release 2.9.0-alpha1. This PR will be automatically marked as merged when #469 merges; please do not close it. Would you like to be credited by real name in the release notes? If so, shall we use the name in your GitHub profile? |
Contributor
Author
|
Thank you. Yes real name in the profile is fine. |
emlun
added a commit
that referenced
this pull request
Apr 20, 2026
As agreed in #467 (comment) and #468 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #466