Merged
Conversation
Contributor
|
This still looks improper, not relying on CoreMIDI-side scheduling if I'm looking at it correctly. Is there any reason for that? I'd just increment the start time and use it for proper MIDI playback. Or is that too hard to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've studied the ALSA implementation and it's scheduler thread. My apologies for the original code and my lack of understanding of midi timing.
I've updated the codebase with a PlayerLoop scheduler that activates every 10 milliseconds. This calls the PlayTick() function that times events by reading from the queue, calculating the timestamp for the event and then sends the midi event to the operating system. The function then updates the NextTickIn counter for the next event.