Remove docs related part since zeppelin-docs module is removed#311
Merged
Conversation
Contributor
|
You should also consider to remove the swagger dependencies too. We dont need to add more dependencies if there is no use for them. |
Contributor
|
@minahlee FYI, we have swagger dependencies on zeppelin-server/pom.xml |
Contributor
|
I created #332 to address issue about dropping swagger dependency. |
|
To complete the picture, why the docs have been removed? Would it make sense to revive the zeppelin-docs webapp? |
Contributor
Contributor
|
If there're no more discussion, i'm merging it. |
Leemoonsoo
added a commit
that referenced
this pull request
Mar 8, 2015
Remove docs related part since zeppelin-docs module is removed
epahomov
pushed a commit
to epahomov/zeppelin
that referenced
this pull request
Jul 23, 2016
So far, the Paragraph's CSS is mixed in the notebook.css file. This PR is made to move Paragraph's CSS to its own file. Author: Damien Corneau <corneadoug@gmail.com> Closes ZEPL#311 from corneadoug/improve/SeparateParagraphCss and squashes the following commits: 59c1676 [Damien Corneau] Improve Report CSS 7f6c877 [Damien Corneau] Final split of Paragraph CSS c2fa5bc [Damien Corneau] Fix CSS files spacing ac626ef [Damien Corneau] More CSS moved to paragraph CSS db178ce [Damien Corneau] Clean up looknfeel css af317cc [Damien Corneau] Moving css to paragraph.css file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#289 PR occured below warning.
java.io.FileNotFoundException: /Users/zeppelin/zeppelin-server/../zeppelin-docs/src/main/swagger
This PR fixes it by removing docs related part.