fix: security hardening and HA deployment guide#224
Merged
Conversation
Replaces fmt.Sprintf string interpolation with encoding/json to correctly escape quotes, newlines, and other special characters in error messages.
Adds an in-memory token bucket rate limiter (stdlib only: sync, time) with one bucket per source IP. The new config field register_ratelimit controls the per-minute limit (0 = unlimited); defaults to 10 in config.cfg.
Base automatically changed from
feature/ai-agent-support
to
feature/dns-api-extended
May 30, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewTXTValuesInTransactionnow uses a parameterized query + prepared statement instead offmt.Sprintfstring interpolation (defense-in-depth — input was already sanitized)jsonError: Usesjson.Marshalinstead offmt.Sprintfto safely encode error messages containing quotes or special characters/register; configured viaregister_ratelimit = 10in[api](0 = unlimited); returns HTTP 429 when exceededcorsoriginsdefault changed from["*"]to[]— deny all cross-origin by default. Breaking change — documented inCHANGELOG.mddocs/ha-deployment.md— active-active deployment with shared PostgreSQL, HAProxy/pgBouncer examples, Kubernetes probes, failure modes table, rolling upgrade procedureDepends on: #223
Breaking Changes
corsoriginsdefault is now[]. Deployments relying on the implicit*must explicitly setcorsorigins = ["*"]in their config.Test Plan
go test ./...passesgo vet ./...clean/registerreturns 429 after exceedingregister_ratelimitfrom same IP/registerfrom a different IP still returns 201 after limit hit on another IPjsonErrorwith a message containing"quotes"produces valid JSONCHANGELOG.mdfor breaking change notedocs/ha-deployment.md