feat: 支持插件内获取及订阅主题相关信息#415
Merged
lzx8589561 merged 1 commit intoZToolsCenter:mainfrom Apr 14, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a theme synchronization mechanism to notify plugins of changes in theme settings, including dark mode, primary colors, and window material. It introduces new APIs in the preload script and broadcasting logic in the main process to ensure all plugin views stay updated. A review comment suggests refactoring redundant broadcasting logic in internal.ts to utilize existing methods in windowManager for better maintainability.
| detachedWindowManager.broadcastToAllWindows('update-primary-color', data) | ||
|
|
||
| // 通知插件主题信息变更 | ||
| windowManager.notifyThemeInfoChanged() |
Contributor
There was a problem hiding this comment.
此处的广播逻辑（L808-L816）与 windowManager.broadcastPrimaryColor 方法中的逻辑重复。为了提高代码的可维护性并避免冗余，建议将该代码块重构为直接调用 windowManager.broadcastPrimaryColor(primaryColor, customColor)。
Collaborator
这块怎么删除了 ？这是我提交的bug修复，需要还原一下
|
Collaborator
Author
|
歪日这蠢AI，总在干一些无关的事，昨晚复查了一部分，没想到还有，抱歉抱歉 |
Particaly
force-pushed
the
feature/plugin-theme-info-support
branch
from
369190f to
810c913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.