-
Notifications
You must be signed in to change notification settings - Fork 44
chore(library): Discontinue V1.0.x-maintenance-branch #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is in preparation for the second maintenance release to Version 1.0.0
This is in preparation for the second maintenance release to Version 1.0.0
…/CRSFforArduino into v1.0.x-Maintenance-Branch
This marks the start of the fourth follow-up release to v1.0.0.
This will help catch vulnerabilities in the v1.0.x maintenance branch before any follow-up releases are made.
…lity Control checks This ensures all Pull Requests and direct pushes that target the `v1.0.x-Maintenance-Branch` MUST successfully compile on all supported development boards.
…132) You can now pass in your own custom baud rate in `sketchLayer::CRSFforArduino::begin()`.
…-Development` CodeQL will now scan `Version-1.1.0-Development` for vulnerabilities instead of `v1.0.x-Maintenance-Branch`
…ion-1.1.0-Development` branch Quality Control will test compatibility, code quality, and formatting on `Version-1.1.0-Development` instead of `v1.0.x-Maintenance-Branch`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL: I can "Approve" or "Request changes" to Pull Requests from others, but not my own. That tracks. 🤔
Anyway, this is me testing that feature in my own Pull Request, because I want to see what happens.
Update: I wonder if this counts toward my "review count", if I were to make an arbitrary branch require approvals of Pull Requests? 🤔
If so, I wonder if I can make it so that said approvals are only required of Pull Requests by others?
Because the last time I tried to set approvals up, I could only set it up as a "global setting" and my own repository was requiring me to review my own Pull Requests - which is not possible, because GitHub won't allow me to review my own Pull Requests in my own public repositories.
Development focus is now on the upcoming Version 1.1.0 of CRSF for Arduino.
Development focus is now on the upcoming Version 1.1.0 of CRSF for Arduino.
Overview
This Pull Request here is a "dummy" for merging
V1.0.x-maintenance-branchinto theMain-Trunk.Details
v1.0.4 was cut from this branch, and it's being merged into the
Main-Trunk.I probably should have done this first and then cut v1.0.4 off the
Main-Trunk, but c'est la vie. It's a learning curve for me, after all. =^/.~=