Conversation
BasilBibi
reviewed
Nov 12, 2018
| def test_01_remove_vowels_from_word_starting_with_vowel(self): | ||
| word = 'abacus' | ||
| self.assertEqual('abcs', remove_vowels(word)) | ||
|
|
Collaborator
There was a problem hiding this comment.
Any more tests you can think of ?
BasilBibi
reviewed
Nov 13, 2018
| vowels = ['a', 'e', 'i', 'o', 'u', 'A', 'E', 'I', 'O', 'U'] | ||
| abbreviation = [] | ||
| abbreviation.append(word[0]) | ||
| for w in word[1:]: |
Collaborator
There was a problem hiding this comment.
Is there a way to turn this for loop into a list comprehension ?
Owner
Author
There was a problem hiding this comment.
I did try this as a list comprehension, and it looks like this:
[abbreviation.append(w)
for w in word[1:]
if w not in vowels]
I do not think it makes it any easier to read.
BasilBibi
approved these changes
Nov 13, 2018
Collaborator
BasilBibi
left a comment
BasilBibi
left a comment
There was a problem hiding this comment.
Ok this is ready to be merged to develop good work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.