fix(): Maybe? who knows

[asturur]

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Updated core detection mechanism to improve compatibility with the native application environment.

[coderabbitai]

📝 Walkthrough

Walkthrough

A one-line update to zaparoo_is_native_core() in alt_launcher.cpp that changes the native core recognition from "Zaparoo Launcher" to "Zaparoo Frontend", updating the string comparison used to identify the native core for CRT-mode initialization.

Changes

Native Core Name Recognition

Layer / File(s)	Summary
Native core name comparison support/zaparoo/alt_launcher.cpp	zaparoo_is_native_core() now matches "Zaparoo Frontend" instead of "Zaparoo Launcher" when determining which cores trigger CRT-mode initialization for the native path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• ZaparooProject/Main_MiSTer#1: Directly related PR that introduced or modified the native CRT launch mode and initial core-name detection logic that this change updates.

Poem

🐰 A core named Frontend hops into view,
Where Launcher once stood, now something new,
One tiny string makes recognition sing,
Native paths dance on a rename's wing! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The pull request title 'fix(): Maybe? who knows' is vague and non-descriptive, using generic phrasing that conveys no meaningful information about the actual change.	Replace the title with a clear, specific summary of the main change, such as 'Update zaparoo_is_native_core() to compare against Zaparoo Frontend instead of Zaparoo Launcher'.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch save-callan-night

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@support/zaparoo/alt_launcher.cpp`:
- Line 550: zaparoo_is_native_core() now compares the core name to "Zaparoo
Frontend" but existing installations may still report "Zaparoo Launcher" and use
the persisted CRT state file zaparoo_launcher_crt.bin; update
zaparoo_is_native_core() to do a case-insensitive match against both "Zaparoo
Frontend" and the legacy "Zaparoo Launcher" (or normalize reported core names)
and add a compatibility path when loading/saving the CRT state so
zaparoo_launcher_crt.bin is accepted/mapped to the new core name; ensure the
logic references the static const char *name and the CRT state filename
zaparoo_launcher_crt.bin so both identification and state file compatibility are
handled.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2db6b0d9-106c-4836-acbf-4fd246a88f22

📥 Commits

Reviewing files that changed from the base of the PR and between 6d10cc2 and c22b6e2.

📒 Files selected for processing (1)

• support/zaparoo/alt_launcher.cpp

[coderabbitai]

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Search for references to "Zaparoo Launcher" string in the codebase
# to ensure all references are updated consistently.

echo "=== Searching for 'Zaparoo Launcher' references ==="
rg -i "zaparoo.launcher" --type=cpp --type=h -C2

echo ""
echo "=== Searching for 'Zaparoo Frontend' references ==="
rg -i "zaparoo.frontend" --type=cpp --type=h -C2

echo ""
echo "=== Checking for any .rbf files that might contain core name metadata ==="
fd -e rbf -e RBF -i zaparoo

Repository: ZaparooProject/Main_MiSTer

Length of output: 6224

---

Native-core CRT auto-init: confirm the core RBF now reports "Zaparoo Frontend"

• support/zaparoo/alt_launcher.cpp zaparoo_is_native_core() now matches the core internal name against "Zaparoo Frontend" (case-insensitive).
• A search in *.cpp/h for zaparoo.launcher finds menu/state-file naming (e.g., zaparoo_launcher_crt.bin) but not an old "Zaparoo Launcher" core-name literal.
• This checkout contains no .rbf/.RBF artifacts to inspect, so it’s not possible here to confirm the shipped core RBF reports "Zaparoo Frontend"—if it still reports "Zaparoo Launcher", native CRT auto-init won’t trigger for existing installations.
• Check backward compatibility for the persisted CRT state file zaparoo_launcher_crt.bin if it’s intended to map to the pre-change naming.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@support/zaparoo/alt_launcher.cpp` at line 550, zaparoo_is_native_core() now
compares the core name to "Zaparoo Frontend" but existing installations may
still report "Zaparoo Launcher" and use the persisted CRT state file
zaparoo_launcher_crt.bin; update zaparoo_is_native_core() to do a
case-insensitive match against both "Zaparoo Frontend" and the legacy "Zaparoo
Launcher" (or normalize reported core names) and add a compatibility path when
loading/saving the CRT state so zaparoo_launcher_crt.bin is accepted/mapped to
the new core name; ensure the logic references the static const char *name and
the CRT state filename zaparoo_launcher_crt.bin so both identification and state
file compatibility are handled.