Skip to content

feat: add launch set name arguments#28

Merged
wizzomafizzo merged 1 commit into
mainfrom
feat/launch-set-name-args
May 26, 2026
Merged

feat: add launch set name arguments#28
wizzomafizzo merged 1 commit into
mainfrom
feat/launch-set-name-args

Conversation

@wizzomafizzo
Copy link
Copy Markdown
Member

@wizzomafizzo wizzomafizzo commented May 26, 2026

Summary

  • add set_name and set_name_same_dir advanced argument keys
  • add shared launch set-name args embedded in launch command arg structs
  • cover new keys and fields with tests

Test

  • go test ./...

Summary by CodeRabbit

  • New Features

    • Added support for advanced naming options (set_name and set_name_same_dir) across multiple launch operations, enabling more flexible configuration of item naming behavior.
  • Tests

    • Added comprehensive test coverage for new naming configuration options and their associated constants.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af5ae7bd-f265-4243-825d-9bc5edb78f98

📥 Commits

Reviewing files that changed from the base of the PR and between 7e7488b and 18178ee.

📒 Files selected for processing (2)
  • types.go
  • types_test.go

📝 Walkthrough

Walkthrough

This PR adds set_name and set_name_same_dir advanced arguments to the zapscript launch command system. A new LaunchSetNameArgs struct is introduced and embedded into five launch-related argument types (LaunchArgs, LaunchRandomArgs, LaunchSearchArgs, LaunchTitleArgs, LaunchLastArgs), with corresponding validation tests.

Changes

Set Name Arguments across Launch Commands

Layer / File(s) Summary
Set Name schema and key constants
types.go
Defines KeySetName and KeySetNameSameDir key constants aligned with existing advarg keys, introduces the exported LaunchSetNameArgs struct with SetName and SetNameSameDir string fields, and embeds it into LaunchArgs to expand the base launch command's supported advanced arguments.
Extend launch command types with LaunchSetNameArgs
types.go
Embeds LaunchSetNameArgs into LaunchRandomArgs, LaunchSearchArgs, LaunchTitleArgs, and LaunchLastArgs to uniformly add set_name and set_name_same_dir support across all launch variant commands.
Field and key constant validation tests
types_test.go
TestLaunchArgsSetNameFields runs in parallel and asserts LaunchArgs.SetName and LaunchArgs.SetNameSameDir contain expected string values; TestLaunchSetNameKeys asserts KeySetName and KeySetNameSameDir equal their expected constant strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With struct embeddings neat and clean,
Set name arguments grace the scene,
Five launch commands now unite,
With constants shining, tests so tight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: add launch set name arguments' directly and clearly describes the main change: adding new launch set name argument functionality to the codebase.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/launch-set-name-args

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wizzomafizzo wizzomafizzo merged commit 2f0458b into main May 26, 2026
11 of 12 checks passed
@wizzomafizzo wizzomafizzo deleted the feat/launch-set-name-args branch May 26, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant