fix(mister): correct alt-core RBF paths and add fuzzy system ID matching #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix 80MHzNintendo64 and 2XPSX launcher RBF paths from _Console/ to _Other/ - Use systemdefs.LookupSystem for fuzzy matching in config system lookups - LookupSystemDefaults now resolves aliases (e.g., "megadrive" -> Genesis) - IsHoldModeIgnoredSystem now resolves aliases for ignore_system config - Add regression tests for fuzzy system ID matching
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues reported by MiSTer users:
80MHzNintendo64and2XPSXalt-core launchers had incorrect hardcoded paths pointing to_Console/instead of_Other/[[systems.default]]andignore_systemconfig options now usesystemdefs.LookupSystemfor fuzzy matching, supporting aliases like "megadrive" → Genesis, "N64" → Nintendo64, etc.Changes
80MHzNintendo64RBF path:_Console/N64_80MHz→_Other/N64_80MHz2XPSXRBF path:_Console/PSX2XCPU→_Other/PSX2XCPULookupSystemDefaults()to usesystemdefs.LookupSystemfor alias resolutionIsHoldModeIgnoredSystem()to usesystemdefs.LookupSystemfor alias resolution