feat(daemon): copy service binary to DataDir instead of tmpfs#610
Merged
wizzomafizzo merged 2 commits intomainfrom Apr 4, 2026
Merged
feat(daemon): copy service binary to DataDir instead of tmpfs#610wizzomafizzo merged 2 commits intomainfrom
wizzomafizzo merged 2 commits intomainfrom
Conversation
Move the service binary copy from TempDir (RAM-backed tmpfs) to DataDir (persistent storage). The kernel demand-pages from disk so only accessed code pages consume RAM, instead of pinning the full ~50MB binary. Also adds -trimpath build flag and tests for prepareBinary.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Port 0 was rejected by isValidAPIPort, causing NewTestConfigWithPort to silently fall back to the default port 7497. Parallel tests then competed for port 7497, causing flaky CI failures in TestSSE_ReceivesNotifications. Allow port 0 through apiPortLocked when set programmatically (tests) while keeping it rejected by SetAPIPort and isValidAPIPort (config files, API). The server now writes the actual bound port back to config when port 0 is used so tests can discover which port to connect to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepareBinaryandcleanupServiceBinarymethods from inline code inStart()/stopService()-trimpathbuild flag for reproducible builds and to strip local filesystem paths from binariesprepareBinary