Add config path to acceptance tests#946
Merged
yaahc merged 3 commits intoZcashFoundation:mainfrom Sep 3, 2020
Merged
Conversation
yaahc
suggested changes
Aug 24, 2020
teor2345
previously requested changes
Aug 25, 2020
Contributor
teor2345
left a comment
teor2345
left a comment
There was a problem hiding this comment.
This PR conflicts with PR #939.
I'd like to merge PR #939 first, and then rewrite this PR to use the new ConfigMode enum:
https://github.com/ZcashFoundation/zebra/pull/939/files#diff-33c347fc0c4532e93ecd68f7cef1fb07R16
teor2345
reviewed
Aug 25, 2020
teor2345
reviewed
Aug 25, 2020
teor2345
reviewed
Aug 25, 2020
teor2345
reviewed
Aug 25, 2020
Contributor
|
I just merged PR #939, please feel free to rebase this PR when you get time. |
oxarbitrage
force-pushed
the
issue943
branch
from
ff1c042 to
cabb7b7
Compare
yaahc
suggested changes
Sep 3, 2020
yaahc
dismissed
teor2345’s stale review
previous comments have been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #943 in the first commit and resolves #976 in the second.