Skip to content

🛡️ Sentinel: [CRITICAL] Fix buffer overflow in ead-client username#19

Merged
manupawickramasinghe merged 4 commits intomainfrom
sentinel-ead-client-bof-3020443831122979615
Mar 19, 2026
Merged

🛡️ Sentinel: [CRITICAL] Fix buffer overflow in ead-client username#19
manupawickramasinghe merged 4 commits intomainfrom
sentinel-ead-client-bof-3020443831122979615

Conversation

@ManupaKDU
Copy link

🚨 Severity: CRITICAL
💡 Vulnerability: Buffer Overflow in ead-client.c where strcpy is used to copy the unbounded username from the command line into a fixed 32-byte buffer.
🎯 Impact: A local attacker could trigger a stack-based buffer overflow by passing an overly long username (e.g. ead-client AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA), potentially leading to arbitrary code execution or a denial of service (crash).
🔧 Fix: Replaced strcpy with strncpy and manually null-terminated the resulting string buffer (sizeof(EAD_DATA(msg, user)->username) - 1).
Verification: Compile package/network/services/ead/src/ and run ./ead-client $(perl -e 'print "A"x50'). The program no longer crashes.


PR created automatically by Jules for task 3020443831122979615 started by @manupawickramasinghe

Signed-off-by: Jules Agent <jules@example.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules bot and others added 3 commits March 19, 2026 01:54
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@manupawickramasinghe manupawickramasinghe merged commit 8f25e82 into main Mar 19, 2026
4 of 7 checks passed
@manupawickramasinghe manupawickramasinghe deleted the sentinel-ead-client-bof-3020443831122979615 branch March 19, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment