🛡️ Sentinel: [CRITICAL] Fix buffer overflow in ead-client username#19
Conversation
Signed-off-by: Jules Agent <jules@example.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
🚨 Severity: CRITICAL
💡 Vulnerability: Buffer Overflow in
ead-client.cwherestrcpyis used to copy the unboundedusernamefrom the command line into a fixed 32-byte buffer.🎯 Impact: A local attacker could trigger a stack-based buffer overflow by passing an overly long username (e.g.
ead-client AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA), potentially leading to arbitrary code execution or a denial of service (crash).🔧 Fix: Replaced
strcpywithstrncpyand manually null-terminated the resulting string buffer (sizeof(EAD_DATA(msg, user)->username) - 1).✅ Verification: Compile
package/network/services/ead/src/and run./ead-client $(perl -e 'print "A"x50'). The program no longer crashes.PR created automatically by Jules for task 3020443831122979615 started by @manupawickramasinghe