Skip to content

Feature share #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2022
Merged

Feature share #504

merged 4 commits into from
Oct 20, 2022

Conversation

@Simon-zhenfeng
Copy link
Collaborator

@Simon-zhenfeng Simon-zhenfeng commented Oct 19, 2022

  1. modify the action buttons stype class name
  2. add the track event for share survey

hanzhenfeng added 4 commits October 16, 2022 18:55
#493: As a user, I want to share the diagram so that they can collabo…
53297be 
…rate with me

1. when user click the button, browser will open a new window show the github survey page
2. regarding the implements:
2.1 I have to add an empty function for the share button, I don't know how to avoid that
2.2 I might need to change the share button position
Merge remote-tracking branch 'origin/master'
5d4c94a
Merge remote-tracking branch 'origin/master'
7c1d37b
Add tract event for share survey
35b4d53
@Simon-zhenfeng Simon-zhenfeng requested review from MrCoder and removed request for MrCoder October 19, 2022 02:15
@MrCoder MrCoder merged commit d45897b into master Oct 20, 2022
@MrCoder MrCoder deleted the feature-share branch October 20, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrCoder MrCoder Awaiting requested review from MrCoder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Simon-zhenfeng @MrCoder