Skip to content

Feature share #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Feature share #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53297be
#493: As a user, I want to share the diagram so that they can collabo…
Oct 16, 2022
5d4c94a
Merge remote-tracking branch 'origin/master'
Oct 16, 2022
7c1d37b
Merge remote-tracking branch 'origin/master'
Oct 18, 2022
35b4d53
Add tract event for share survey
Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/ContentWrap.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,10 @@ export default class ContentWrap extends Component {
trackEvent('ui', 'downloadJpeg');
}

shareClickHandler(e) {
trackEvent('ui', 'shareSurvey');
}

async resetSplitting() {
await this.setState({
codeSplitSizes: this.getCodeSplitSizes(),
Expand Down Expand Up @@ -765,8 +769,6 @@ export default class ContentWrap extends Component {
this.cm.js.setValue(codeService.addCode(code, param));
}

gotoShareSurvey() {}

render() {
return (
<SplitPane
Expand Down Expand Up @@ -1003,13 +1005,13 @@ export default class ContentWrap extends Component {
<div class="demo-side" id="js-demo-side" style="overflow-y: auto; -webkit-overflow-scrolling: touch;">
{window.zenumlDesktop ? (null) : (
<div className='promotion'>
<div className="downloads">
<div className="actions">
<a href='https://github.com/ZenUml/web-sequence/discussions/496' target="_blank"
style={{textDecoration:'none'}}>
<Button
className="btn--dark button icon-button hint--rounded hint--bottom-left"
aria-label="Share Your Work"
onClick={this.gotoShareSurvey.bind()}>
onClick={this.shareClickHandler.bind(this)}>
<span className="material-symbols-outlined">share</span>
<span>Share</span>
</Button>
Expand Down
2 changes: 1 addition & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ body:not(.light-version).overlay-visible .main-container {
font-weight: lighter;
}

.demo-side .promotion .downloads {
.demo-side .promotion .actions {
margin-left: auto;
display: flex;
align-items: center;
Expand Down