Conversation
There was a problem hiding this comment.
I've got 2 comments for you to consider
The PR title and description are not accurate. Here are my suggestions:
Title: ci(ruff): upgrade to v0.12.2 and migrate to ruff-check hook
Description: # Contributor Comments
This updates the pre-commit configuration for ruff:
- Upgrades ruff from v0.12.1 to v0.12.2
- Migrates from the deprecated
ruffhook ID to the newruff-checkhook ID - Updates other repository versions to newer nightly builds
The ruff-check hook is the replacement for the deprecated ruff hook.
Pull Request Checklist
Thank you for submitting a contribution!
Please address the following items:
- If you are adding a dependency, please explain how it was chosen.
- If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
- Validate that documentation is accurate and aligned to any project updates or additions.
List of skipped files
Reviewed with 🤟 by Zenable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This moves the
pre-commitconfig to useruff-checkwhich is the replacement forruffand runs a globaltask updatePull Request Checklist
Thank you for submitting a contribution!
Please address the following items: